[ovs-dev] [PATCH 0/1] Encap & Decap actions for MPLS Packet Type
martinvarghesenokia at gmail.com
Thu Oct 10 03:17:34 UTC 2019
On Wed, Oct 09, 2019 at 11:31:44AM -0700, Ben Pfaff wrote:
> On Tue, Oct 08, 2019 at 08:13:16AM +0530, Martin Varghese wrote:
> > The existing PUSH MPLS & POP MPLS actions inserts & removes MPLS header
> > between ethernet header and the IP header. Though this behaviour is fine
> > for L3 VPN where an IP packet is encapsulated inside a MPLS tunnel, it does
> > not suffice the L2 VPN requirements. In L2 VPN the ethernet packets must be
> > encapsulated inside MPLS tunnel.
> Thanks a lot for working to make OVS better.
> I have a few minor comments on the code. I didn't look at it in detail.
> This patch adds a few lines that exceed the normal 79-column limit.
> checkpatch reports those. It's better to wrap lines to fit.
> The compiler reports a few warnings that should be fixed:
> ../ofproto/ofproto-dpif-ipfix.c:2980:17: error: enumeration values 'OVS_ACTION_ATTR_PTAP_PUSH_MPLS' and 'OVS_ACTION_ATTR_PTAP_POP_MPLS' not explicitly handled in switch [-Werror,-Wswitch-enum]
> ../ofproto/ofproto-dpif-sflow.c:1130:17: error: enumeration values 'OVS_ACTION_ATTR_PTAP_PUSH_MPLS' and 'OVS_ACTION_ATTR_PTAP_POP_MPLS' not explicitly handled in switch [-Werror,-Wswitch-enum]
> The biggest issue, however, is a process one. Updates to the kernel
> module need to go upstream to net-next before we put them into the OVS
> tree. Have you submitted them there yet?
> It also would be a good idea to implement this in the OVS userspace
> I suggest adding an item to NEWS to mention the new feature.
Thanks for your time.
I was trying to get the feeback for the approach taken.
I will go ahead and send the kernel changes to net-next
More information about the dev