[ovs-dev] Fwd: [PATCH ovn v2] Utilities: add ovn-sim

Aaron Conole aconole at redhat.com
Thu Oct 10 19:09:29 UTC 2019


Flavio Fernandes <flavio at flaviof.com> writes:

> Hi Aaron,
>
> I think the robot is wrong in thinking there is an issue here; but then again I may the one who is wrong. :^)

You're not wrong, but you're not right :)

There is an issue with checkpatch.py since the regex on line 415 won't
match anything (in this case).  I guess the doc-only check didn't
accommodate this kind of use case.

> The new file 'doc ovn-sim.1.rst' is part of $RST_MANPAGES_NOINST so I think it should not be listed
> twice [1].
>
> Make sense?
>
> -- flaviof
>
> [1]:
> https://github.com/flavio-fernandes/ovn/blob/ovnsim.merge.2/Documentation/automake.mk#L109
>
>  Begin forwarded message:
>
>  From: 0-day Robot <robot at bytheb.org>
>  Subject: Re: [ovs-dev] [PATCH ovn v2] Utilities: add ovn-sim
>  Date: October 10, 2019 at 6:56:58 AM EDT
>  To: Flavio Fernandes <flavio at flaviof.com>
>  Cc: dev at openvswitch.org
>
>  Bleep bloop.  Greetings Flavio Fernandes, I am a robot and I have tried out your patch.
>  Thanks for your contribution.
>
>  I encountered some error that I wasn't expecting.  See the details below.
>
>  checkpatch:
>  WARNING: New doc ovn-sim.1.rst not listed in Documentation/automake.mk
>  Lines checked: 813, Warnings: 1, Errors: 0
>
>  Please check this out.  If you feel there has been an error, please email aconole at redhat.com
>
>  Thanks,
>  0-day Robot


More information about the dev mailing list