[ovs-dev] [PATCH] netdev-afxdp: Fix umem creation failure due to uninitialized config.

William Tu u9012063 at gmail.com
Fri Oct 11 16:14:16 UTC 2019


On Fri, Oct 11, 2019 at 01:16:55PM +0200, Ilya Maximets wrote:
> On 10.10.2019 20:21, William Tu wrote:
> >On Wed, Oct 09, 2019 at 04:17:58PM +0200, Ilya Maximets wrote:
> >>Later version of 'struct xsk_umem_config' contains additional field
> >>'flags'.  OVS doesn't use that field passing uninitialized stack
> >>memory to the 'xsk_umem__create()' call that could fail with
> >>'Invalid argument' if 'flags' are non-zero or, even worse, create
> >>umem with unexpected properties.
> >>
> >>We need to clear the whole structure explicitly to avoid this kind
> >>of issues.
> >>
> >>Fixes: 0de1b425962d ("netdev-afxdp: add new netdev type for AF_XDP.")
> >>Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> >>---
> >
> >Thanks for the patch.
> >I applied to master.
> 
> Thanks, William.
> As this is a bug fix it needs to be backported to 2.12.
> 
> Best regards, Ilya Maximets.

Done, Thanks
William


More information about the dev mailing list