[ovs-dev] [PATCH V1] Add offload packets statistics

Ben Pfaff blp at ovn.org
Mon Oct 14 19:15:55 UTC 2019


On Fri, Oct 11, 2019 at 11:46:29AM +0800, zhaozhanxu wrote:
> Add argument '-m' for command ovs-appctl bridge/dump-flows
> to display the offloaded packets statistics.

This seems like a reasonable addition, and the code looks OK too.

Before, with 2 pointers as function parameters, it was OK to have them
individually.  I am less comfortable with 4 pointers as function
parameters.  Did you consider defining a structure?  It might make the
code better.

Thanks,

Ben.


More information about the dev mailing list