[ovs-dev] [PATCH v1 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

Ben Pfaff blp at ovn.org
Mon Oct 14 22:33:25 UTC 2019

On Wed, Oct 09, 2019 at 04:56:40PM -0700, amginwal at gmail.com wrote:
> From: Aliasgar Ginwala <aginwala at ebay.com>
> Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for
> ovn-nbctl and ovn-sbctl respectively where user can set any single
> supported option. e.g export OVN_NBCTL_OPTIONS=--no-leader-only.
> Above env var OVN_NBCTL_OPTIONS have no effect if user runs
> command as ovn-nbctl --no-leader-only <command>
> Signed-off-by: Aliasgar Ginwala <aginwala at ebay.com>

I think that this could be factored out into lib/command-line.c rather
than done as a copy-and-paste into two files.

I don't think that the ops_passed variable needs to be static.

More information about the dev mailing list