[ovs-dev] [PATCH V1] Add offload packets statistics

zhaozhanxu zhaozhanxu at 163.com
Tue Oct 15 07:01:09 UTC 2019


Thanks for your advise, I modified the parameters form 'uint64_t packet_count' and 'uint64_t byte_count' to 'struct pkts_stats'.
New commit: https://mail.openvswitch.org/pipermail/ovs-dev/2019-October/363518.html


At 2019-10-15 03:15:55, "Ben Pfaff" <blp at ovn.org> wrote:
>On Fri, Oct 11, 2019 at 11:46:29AM +0800, zhaozhanxu wrote:
>> Add argument '-m' for command ovs-appctl bridge/dump-flows
>> to display the offloaded packets statistics.
>
>This seems like a reasonable addition, and the code looks OK too.
>
>Before, with 2 pointers as function parameters, it was OK to have them
>individually.  I am less comfortable with 4 pointers as function
>parameters.  Did you consider defining a structure?  It might make the
>code better.
>
>Thanks,
>
>Ben.


More information about the dev mailing list