[ovs-dev] [PATCH 3/5] compat: remove the incorrect mtu limit for erspan

Yi-Hung Wei yihung.wei at gmail.com
Tue Oct 15 18:07:52 UTC 2019


On Wed, Oct 9, 2019 at 2:25 PM Greg Rose <gvrose8192 at gmail.com> wrote:
>
> From: Haishuang Yan <yanhaishuang at cmss.chinamobile.com>
>
> Upstream commit:
>     commit 0e141f757b2c78c983df893e9993313e2dc21e38
>     Author: Haishuang Yan <yanhaishuang at cmss.chinamobile.com>
>     Date:   Fri Sep 27 14:58:20 2019 +0800
>
>     erspan: remove the incorrect mtu limit for erspan
>
>     erspan driver calls ether_setup(), after commit 61e84623ace3
>     ("net: centralize net_device min/max MTU checking"), the range
>     of mtu is [min_mtu, max_mtu], which is [68, 1500] by default.
>
>     It causes the dev mtu of the erspan device to not be greater
>     than 1500, this limit value is not correct for ipgre tap device.
>
>     Tested:
>     Before patch:
>     # ip link set erspan0 mtu 1600
>     Error: mtu greater than device maximum.
>     After patch:
>     # ip link set erspan0 mtu 1600
>     # ip -d link show erspan0
>     21: erspan0 at NONE: <BROADCAST,MULTICAST> mtu 1600 qdisc noop state DOWN
>     mode DEFAULT group default qlen 1000
>         link/ether 00:00:00:00:00:00 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 68 maxmtu 0
>
>     Fixes: 61e84623ace3 ("net: centralize net_device min/max MTU checking")
>     Signed-off-by: Haishuang Yan <yanhaishuang at cmss.chinamobile.com>
>     Signed-off-by: David S. Miller <davem at davemloft.net>
>
> Cc: Haishuang Yan <yanhaishuang at cmss.chinamobile.com>
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---
LGTM.

Acked-by: Yi-Hung Wei <yihung.wei at gmail.com>


More information about the dev mailing list