[ovs-dev] [PATCH v2] netdev-dpdk: Track vhost tx contention.

David Marchand david.marchand at redhat.com
Sun Oct 20 12:31:15 UTC 2019


Hello,

On Tue, Oct 15, 2019 at 2:13 PM Ilya Maximets <i.maximets at ovn.org> wrote:
>
> On 14.10.2019 20:04, Aaron Conole wrote:
> > David Marchand <david.marchand at redhat.com> writes:
> >
> >> Add a coverage counter to help diagnose contention on the vhost txqs.
> >> This is seen as dropped packets on the physical ports for rates that
> >> are usually handled fine by OVS.
> >> Document how to further debug this contention with perf.
> >>
> >> Signed-off-by: David Marchand <david.marchand at redhat.com>
> >> ---
> >> Changelog since v1:
> >> - added documentation as a bonus: not sure this is the right place, or if it
> >>    really makes sense to enter into such details. But I still find it useful.
> >>    Comments?
> >
> > It's useful, and I think it makes sense here.
>
> That's an interesting debug method, but it looks not very suitable
> for an end-user documentation.  One thing that bothers me the most
> is referencing C code snippets in this kind of documentation.

Ok, can we conclude on the coverage counter wrt the v1 then?
https://patchwork.ozlabs.org/patch/1153238/

Should I submit a v3 with the doc update (but removing the parts about perf) ?


Thanks.

-- 
David Marchand


More information about the dev mailing list