[ovs-dev] [PATCH] lacp: report desync in ovs threads enabling slave

Gowrishankar Muthukrishnan gmuthukr at redhat.com
Tue Oct 22 05:29:14 UTC 2019

It is helpful in reporting main thread that is yet to enable bond slave,
but link state was brought up by lacp thread and capture this desync
between ovs threads for debugging.

Fixes: a8448cb170 ("lacp: Avoid packet drop on LACP bond after link up")
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr at redhat.com>
 ofproto/bond.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/ofproto/bond.c b/ofproto/bond.c
index c5d5f2c03..3b148a244 100644
--- a/ofproto/bond.c
+++ b/ofproto/bond.c
@@ -817,6 +817,10 @@ bond_check_admissibility(struct bond *bond, const void *slave_,
          * When may_enable is TRUE, it means LACP is UP and waiting for the
          * main thread to run LACP state machine and enable the slave. */
         verdict = (slave->enabled || slave->may_enable) ? BV_ACCEPT : BV_DROP;
+        if (!slave->enabled && slave->may_enable) {
+            VLOG_DBG_RL(&rl, "bond %s: slave %s: main thread not yet enabled slave",
+                         bond->name, bond->active_slave->name);
+        }
         goto out;
         if (!bond->lacp_fallback_ab) {

More information about the dev mailing list