[ovs-dev] [PATCH v2] dpif-netdev: log rxq assignment in isolated pmd

Gowrishankar Muthukrishnan gmuthukr at redhat.com
Tue Oct 22 09:34:46 UTC 2019


There is no log about isolated rxq assignment in a pmd today, which
sometimes could be useful to trace rxq/pmd pinning, when debugging
with log. Ovs-appctl dpif-netdev/pmd-rxq-show reports about it
already, but logging is helpful to trace pinning in time.

Changes:
  v2: init numa_id for the info.

Reported-at: https://bugzilla.redhat.com/1728616
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr at redhat.com>
---
 lib/dpif-netdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c
index 4546b55e8..4d7c36787 100644
--- a/lib/dpif-netdev.c
+++ b/lib/dpif-netdev.c
@@ -4573,6 +4573,11 @@ rxq_scheduling(struct dp_netdev *dp, bool pinned) OVS_REQUIRES(dp->port_mutex)
                     q->pmd = pmd;
                     pmd->isolated = true;
                     dp_netdev_pmd_unref(pmd);
+                    numa_id = netdev_get_numa_id(q->port->netdev);
+                    VLOG_INFO("Core %d on numa node %d assigned port \'%s\' "
+                          "rx queue %d.", pmd->core_id, numa_id,
+                          netdev_rxq_get_name(q->rx),
+                          netdev_rxq_get_queue_id(q->rx));
                 }
             } else if (!pinned && q->core_id == OVS_CORE_UNSPEC) {
                 uint64_t cycle_hist = 0;
-- 
2.17.2



More information about the dev mailing list