[ovs-dev] [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

[Sriram Vatala]

Thanks Ilya and Kevin.
I will send the updated patch set.

Thanks & Regards,
Sriram.

-----Original Message-----
From: Ilya Maximets <i.maximets at ovn.org>
Sent: 22 October 2019 16:07
To: Kevin Traynor <ktraynor at redhat.com>; Sriram Vatala 
<sriram.v at altencalsoftlabs.com>; 'Ilya Maximets' <i.maximets at ovn.org>; 
ovs-dev at openvswitch.org
Cc: 'Stokes, Ian' <ian.stokes at intel.com>
Subject: Re: [PATCH v9 2/2] netdev-dpdk:Detailed packet drop statistics

On 22.10.2019 12:31, Kevin Traynor wrote:
> On 22/10/2019 09:25, Sriram Vatala wrote:
>> Hi Ilya & Kevin,
>> Thanks for your suggestions. I am summarizing our discussion, please
>> feel free to correct me, if I am wrong.
>>
>
> Hi Sriram,
>
> Will share my thought, Ilya may have different view.
>
>> 1) All custom stats calculated in OVS will have the prefix , so that
>> these stats will not intersect with the names of other stats (driver/HW 
>> etc).
>
> yes
>
>> 2) The prefix used for these custom stats is "cstat_".
>
> I think with 3) (note to explain the prefix) then 'sw_' or 'ovs_'
> would look neater in the logs but i'm ok with any of them.

OK. Lets go with 'ovs_' prefix + prefix explanation note in this case.
It looks like it will have lowest chances to overlap with existing stats.
And it also self-descriptive enough for those who doesn't read docs.

Best regards, Ilya Maximets.