[ovs-dev] [PATCH net] net: openvswitch: free vport unless register_netdevice() succeeds

Stefano Brivio sbrivio at redhat.com
Wed Oct 23 00:20:53 UTC 2019


Hi Jakub,

On Tue, 22 Oct 2019 14:53:16 -0700
Jakub Kicinski <jakub.kicinski at netronome.com> wrote:

> On Mon, 21 Oct 2019 12:01:57 +0200, Stefano Brivio wrote:
> > From: Hillf Danton <hdanton at sina.com>
> > 
> > syzbot found the following crash on:  
>  
> > The function in net core, register_netdevice(), may fail with vport's
> > destruction callback either invoked or not. After commit 309b66970ee2,  
> 
> I've added the correct commit quote here, please heed checkpatch'es
> warnings.

I disregarded this warning as it looks redundant to me, given that the
full commit quote is already given in the Fixes: tag below.

In this specific case, I guess it doesn't really make a difference, but
sometimes one needs to mention the same commit multiple times in the
actual message, and while checkpatch would complain about every single
instance, I think that providing the full quote for each of them isn't
very useful and hinders readability.

> > Reported-by: syzbot+13210896153522fe1ee5 at syzkaller.appspotmail.com
> > Fixes: 309b66970ee2 ("net: openvswitch: do not free vport if register_netdevice() is failed.")
> > Cc: Taehee Yoo <ap420073 at gmail.com>
> > Cc: Greg Rose <gvrose8192 at gmail.com>
> > Cc: Eric Dumazet <eric.dumazet at gmail.com>
> > Cc: Marcelo Ricardo Leitner <marcelo.leitner at gmail.com>
> > Cc: Ying Xue <ying.xue at windriver.com>
> > Cc: Andrey Konovalov <andreyknvl at google.com>
> > Signed-off-by: Hillf Danton <hdanton at sina.com>
> > Acked-by: Pravin B Shelar <pshelar at ovn.org>
> > [sbrivio: this was sent to dev at openvswitch.org and never made its way
> >  to netdev -- resending original patch]
> > Signed-off-by: Stefano Brivio <sbrivio at redhat.com>
> > ---
> > This patch was sent to dev at openvswitch.org and appeared on netdev
> > only as Pravin replied to it, giving his Acked-by. I contacted the
> > original author one month ago requesting to resend this to netdev,
> > but didn't get an answer, so I'm now resending the original patch.  
> 
> Applied and queued for 4.14+, thanks!

Thank you!

-- 
Stefano



More information about the dev mailing list