[ovs-dev] [PATCH] lldp: Fix for OVS crashes when a LLDP-enabled port is deleted

Ben Pfaff blp at ovn.org
Thu Oct 24 19:57:53 UTC 2019


On Mon, Oct 21, 2019 at 12:42:02PM +0530, Surya Rudra via dev wrote:
> Issue:
> When LLDP is enabled on a port, a structure to hold LLDP related state
> is created and that structure has a reference to the port. The ofproto
> monitor thread accesses the LLDP structure to periodically send packets
> over the associated port. When the port is deleted, the LLDP structure
> is not cleaned up and it continues to refer to the deleted port.
> 
> When the monitor thread attempts to access the deleted port OVS crashes.
> Crash can happen with bridge delete and bond delete also.
> 
> Fix:
> Remove all references to the LLDP structure and free it when
> the port is deleted.
> 
> Signed-off-by: Surya Rudra <rudrasurya.r at altencalsoftlabs.com>

Thank you for the bug fix.  I applied this to master and I am in the
process of backporting it to older branches.


More information about the dev mailing list