[ovs-dev] [PATCH] lacp: warn transmit failure of lacp pdu

Ben Pfaff blp at ovn.org
Thu Oct 24 20:31:57 UTC 2019


On Mon, Oct 21, 2019 at 07:34:36PM +0530, Gowrishankar Muthukrishnan wrote:
> It might be difficult to trace whether LACP PDU tx (as in
> response) was successful when the pdu was not transmitted by
> egress slave for various reasons (including resource contention
> within NIC) and only way to trace its fate is by looking at
> ofproto->stats.tx_[packets/bytes] and slave port stats.
> 
> Adding a warning when there is tx failure could help user
> debug at the root of this problem.
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr at redhat.com>

This logic seems like it's probably true for all users of
ofproto_dpif_send_packet(), not just LACP PDU transmission.  Would it be
a good idea to simply make ofproto_dpif_send_packet() log a warning when
tx fails?


More information about the dev mailing list