[ovs-dev] [PATCH v1] command-line.c: Support parsing ctl options via env variable

Ben Pfaff blp at ovn.org
Fri Oct 25 01:14:05 UTC 2019


On Tue, Oct 15, 2019 at 06:52:34PM -0700, amginwal at gmail.com wrote:
> From: Aliasgar Ginwala <aginwala at ebay.com>
> 
> Signed-off-by: Aliasgar Ginwala <aginwala at ebay.com>

I'm pretty sure this code doesn't work properly because it tries to
parse the same string twice with strtok_r(), which is going to truncate
it after the first option.  Did you try it with more than one
space-separated option in the environment variable?

lib/svec.[ch] would make it easier to write this.


More information about the dev mailing list