[ovs-dev] [PATCH ovn] controller: Downgrade a warning log message

Russell Bryant russell at ovn.org
Fri Oct 25 13:36:46 UTC 2019


This log message was introduced in commit 5344f24ecb.  It gets hit
under normal circumstances, so it would be better as a debug message
instead of a warning.  I also expanded it to clarify that the next
step will be to create the chassis record.

This was found by trying to run the system-ovn.at tests, and they
failed because of these unexpected warning log messages.

Signed-off-by: Russell Bryant <russell at ovn.org>
---
 controller/chassis.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/controller/chassis.c b/controller/chassis.c
index 699b66281..978273e19 100644
--- a/controller/chassis.c
+++ b/controller/chassis.c
@@ -484,8 +484,9 @@ chassis_get_record(struct ovsdb_idl_txn *ovnsb_idl_txn,
         chassis_rec = chassis_lookup_by_name(sbrec_chassis_by_name,
                                              chassis_info_id(&chassis_state));
         if (!chassis_rec) {
-            VLOG_WARN("Could not find Chassis : stored (%s) ovs (%s)",
-                      chassis_info_id(&chassis_state), chassis_id);
+            VLOG_DBG("Could not find Chassis, will create it"
+                     ": stored (%s) ovs (%s)",
+                     chassis_info_id(&chassis_state), chassis_id);
             if (ovnsb_idl_txn) {
                 /* Recreate the chassis record.  */
                 chassis_rec = sbrec_chassis_insert(ovnsb_idl_txn);
-- 
2.21.0



More information about the dev mailing list