[ovs-dev] [PATCH] flow: Fix crash on vlan packets with partial offloading.

Ilya Maximets i.maximets at ovn.org
Fri Oct 25 16:52:32 UTC 2019


On 24.10.2019 22:00, Ben Pfaff wrote:
> On Thu, Oct 24, 2019 at 12:09:16PM +0200, Ilya Maximets wrote:
>> parse_tcp_flags() does not care about vlan tags in a packet thus
>> not able to parse them.  As a result, if partial offloading is
>> enabled in userspace datapath vlan packets are not parsed, i.e.
>> has no initialized offsets.  This causes OVS crash on any attempt
>> to access/modify packet header fields.
> 
> Thanks!  Good catch!
> 
> Acked-by: Ben Pfaff <blp at ovn.org>

Thanks! Applied to master and backported down to 2.10.

Best regards, Ilya Maximets.


More information about the dev mailing list