[ovs-dev] [PATCH] lacp: warn transmit failure of lacp pdu

Gowrishankar Muthukrishnan gmuthukr at redhat.com
Tue Oct 29 08:51:13 UTC 2019


Hi Ben,
Idea is to log lacp specific tx failure. A one step further as in
ofproto_dpif_send_packet has to make the debug info more generic, even
though it would cater all of its calling functions.
For example, bundle_send_learning_packets reports such tx failures for
gratuitous packets. I think, we need to handle such warning at the calling
place itself to debug quickly.

Thanks,
Gowrishankar

On Fri, Oct 25, 2019 at 2:47 AM Ben Pfaff <blp at ovn.org> wrote:

> On Mon, Oct 21, 2019 at 07:34:36PM +0530, Gowrishankar Muthukrishnan wrote:
> > It might be difficult to trace whether LACP PDU tx (as in
> > response) was successful when the pdu was not transmitted by
> > egress slave for various reasons (including resource contention
> > within NIC) and only way to trace its fate is by looking at
> > ofproto->stats.tx_[packets/bytes] and slave port stats.
> >
> > Adding a warning when there is tx failure could help user
> > debug at the root of this problem.
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukr at redhat.com>
>
> This logic seems like it's probably true for all users of
> ofproto_dpif_send_packet(), not just LACP PDU transmission.  Would it be
> a good idea to simply make ofproto_dpif_send_packet() log a warning when
> tx fails?
>


More information about the dev mailing list