[ovs-dev] [PATCH ovn 4/6] northd: Add lflows for IPv6 NAT.

0-day Robot robot at bytheb.org
Wed Oct 30 02:03:21 UTC 2019


Bleep bloop.  Greetings Russell Bryant, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#86 FILE: northd/ovn-northd.c:6095:
                    static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);

WARNING: Line is 82 characters long (recommended limit is 79)
#192 FILE: northd/ovn-northd.c:6980:
                    static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);

WARNING: Line is 83 characters long (recommended limit is 79)
#247 FILE: northd/ovn-northd.c:7026:
                              "inport == %s && arp.tpa == "IP_FMT" && arp.op == 1",

WARNING: Line is 81 characters long (recommended limit is 79)
#367 FILE: northd/ovn-northd.c:7176:
                    && op->lrp_networks.ipv4_addrs[i].addr == snat_ips[j].ipv4) {

WARNING: Line is 82 characters long (recommended limit is 79)
#470 FILE: northd/ovn-northd.c:7420:
                    static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(5, 1);

WARNING: Line is 81 characters long (recommended limit is 79)
#476 FILE: northd/ovn-northd.c:7426:
                /* It was an invalid IPv4 address, but valid IPv6. Treat the rest

WARNING: Line is 123 characters long (recommended limit is 79)
#500 FILE: northd/ovn-northd.c:7450:
                if (error || (!is_v6 && mask != OVS_BE32_MAX) || (is_v6 && memcmp(&mask_v6, &v6_exact, sizeof(mask_v6)))) {

Lines checked: 687, Warnings: 7, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list