[ovs-dev] [dpdk-latest PATCH] sparse: Remove dpdk network headers copies.

Stokes, Ian ian.stokes at intel.com
Wed Oct 30 15:26:14 UTC 2019



On 10/28/2019 9:00 AM, David Marchand wrote:
> Now that dpdk headers annotates the network header structures with
> endianness [1], we can get rid of these copies.
> 
> 1: https://git.dpdk.org/dpdk/commit/?id=7eca7f7fd09d
> 
> Signed-off-by: David Marchand <david.marchand at redhat.com>
> ---
>   include/sparse/automake.mk |   6 -
>   include/sparse/rte_esp.h   |  65 ------
>   include/sparse/rte_icmp.h  | 106 ----------
>   include/sparse/rte_ip.h    | 490 ---------------------------------------------
>   include/sparse/rte_sctp.h  | 103 ----------
>   include/sparse/rte_tcp.h   | 108 ----------
>   include/sparse/rte_udp.h   | 103 ----------
>   7 files changed, 981 deletions(-)
>   delete mode 100644 include/sparse/rte_esp.h
>   delete mode 100644 include/sparse/rte_icmp.h
>   delete mode 100644 include/sparse/rte_ip.h
>   delete mode 100644 include/sparse/rte_sctp.h
>   delete mode 100644 include/sparse/rte_tcp.h
>   delete mode 100644 include/sparse/rte_udp.h

Thanks for this David,

seems OK to me, tested locally and with travis CI. No issues seen.

https://travis-ci.org/istokes/ovs/builds/604905322

Please note I've re-based dpdk-latest with master for this testing. I'm 
going to push the re-based dpdk-latest branch today along with this 
patch as DPDK 19.11 RC1 is now available.

Regards
Ian


More information about the dev mailing list