[ovs-dev] [PATCH] Avoid indeterminate statistics in offload implementations.

Ilya Maximets i.maximets at ovn.org
Wed Oct 30 19:40:22 UTC 2019


On 25.10.2019 20:46, Ben Pfaff wrote:
> A lot of the offload implementations didn't bother to initialize the
> statistics they were supposed to return.  I don't know whether any of
> the callers actually use them, but it looked wrong.
> 
> Found by inspection.
> 
> Signed-off-by: Ben Pfaff <blp at ovn.org>
> ---
>   lib/netdev-dummy.c        | 10 ++++++++--
>   lib/netdev-offload-dpdk.c | 10 ++++++++--
>   lib/netdev-offload-tc.c   |  5 ++++-
>   3 files changed, 20 insertions(+), 5 deletions(-)

This looks correct.
'dummy' and 'dpdk' implementations doesn't support stats at all, so
these should be cleared. 'tc' needs some more work to return stats
on flow replacing, but this should be a separate change.

Acked-by: Ilya Maximets <i.maximets at ovn.org>


More information about the dev mailing list