[ovs-dev] [PATCH dpdk-latest] dpdk: Migrate to the new pdump API.

Ilya Maximets i.maximets at ovn.org
Wed Oct 30 20:50:42 UTC 2019


DPDK commit 660098d61f57 ("pdump: use generic multi-process channel")
switched pdump to use generic DPDK IPC instead of sockets.
Old API was deprecated and removed.  Updating OVS code accordingly.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
---

Compile tested only.

BTW, does anybode uses this functionality?
I mean, the conventional way for dumping packets in OVS is to use
ovs-tcpdump that works via traffic mirroring.  I guess, pdump
could be used for some lower level debuging, but I never used it.

 lib/dpdk.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/lib/dpdk.c b/lib/dpdk.c
index f90cda75a..611bc241f 100644
--- a/lib/dpdk.c
+++ b/lib/dpdk.c
@@ -27,7 +27,6 @@
 #include <rte_memzone.h>
 #include <rte_version.h>
 #ifdef DPDK_PDUMP
-#include <rte_mempool.h>
 #include <rte_pdump.h>
 #endif
 
@@ -434,17 +433,10 @@ dpdk_init__(const struct smap *ovs_other_config)
 
 #ifdef DPDK_PDUMP
     VLOG_INFO("DPDK pdump packet capture enabled");
-    err = rte_pdump_init(ovs_rundir());
+    err = rte_pdump_init();
     if (err) {
         VLOG_INFO("Error initialising DPDK pdump");
         rte_pdump_uninit();
-    } else {
-        char *server_socket_path;
-
-        server_socket_path = xasprintf("%s/%s", ovs_rundir(),
-                                       "pdump_server_socket");
-        fatal_signal_add_file_to_unlink(server_socket_path);
-        free(server_socket_path);
     }
 #endif
 
-- 
2.17.1



More information about the dev mailing list