[ovs-dev] [PATCH ovn v2 03/13] ovn-isb: Interconnection southbound DB schema and CLI.

0-day Robot robot at bytheb.org
Wed Oct 30 22:03:19 UTC 2019


Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 80 characters long (recommended limit is 79)
#271 FILE: ovn-isb.ovsschema:34:
                                             "refTable": "Availability_Zone"}}},

WARNING: Line is 80 characters long (recommended limit is 79)
#310 FILE: ovn-isb.ovsschema:73:
                                             "refTable": "Availability_Zone"}}},

WARNING: Line is 82 characters long (recommended limit is 79)
#402 FILE: ovn-isb.xml:30:
    These tables contain objects that are availability zone specific.  Each object

WARNING: Line is 83 characters long (recommended limit is 79)
#403 FILE: ovn-isb.xml:31:
    is owned and populated by one availability zone, and read by other availability

WARNING: Line is 82 characters long (recommended limit is 79)
#468 FILE: ovn-isb.xml:96:
      Each row in this table represents an Availability Zone.  Each OVN deployment

WARNING: Line is 81 characters long (recommended limit is 79)
#469 FILE: ovn-isb.xml:97:
      is considered an availability zone from OVN control plane perspective, with

WARNING: Line is 81 characters long (recommended limit is 79)
#470 FILE: ovn-isb.xml:98:
      its own central components, such as northbound and southbound databases and

WARNING: Line is 81 characters long (recommended limit is 79)
#578 FILE: ovn-isb.xml:206:
        see <ref table="Datapath_Binding" column="tunnel_key"/> column of the OVN

WARNING: Line is 81 characters long (recommended limit is 79)
#579 FILE: ovn-isb.xml:207:
        Southbound database's <ref table="Datapath_Binding" db="OVN_Southbound"/>

WARNING: Line is 81 characters long (recommended limit is 79)
#647 FILE: ovn-isb.xml:275:
          The Ethernet address and IP addresses used by the corresponding logical

WARNING: Line is 84 characters long (recommended limit is 79)
#648 FILE: ovn-isb.xml:276:
          router port peering with the transit switch port.  It is a string combined

WARNING: Line is 82 characters long (recommended limit is 79)
#691 FILE: ovn-isb.xml:319:
          <dt><code>ssl:<var>host</var></code>[<code>:<var>port</var></code>]</dt>

WARNING: Line is 82 characters long (recommended limit is 79)
#709 FILE: ovn-isb.xml:337:
          <dt><code>tcp:<var>host</var></code>[<code>:<var>port</var></code>]</dt>

WARNING: Line is 84 characters long (recommended limit is 79)
#715 FILE: ovn-isb.xml:343:
              address, wrap it in square brackets, e.g. <code>tcp:[::1]:6640</code>.

WARNING: Line is 85 characters long (recommended limit is 79)
#721 FILE: ovn-isb.xml:349:
          <dt><code>pssl:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>

WARNING: Line is 80 characters long (recommended limit is 79)
#733 FILE: ovn-isb.xml:361:
              A valid SSL configuration must be provided when this form is used,

WARNING: Line is 85 characters long (recommended limit is 79)
#745 FILE: ovn-isb.xml:373:
          <dt><code>ptcp:</code>[<var>port</var>][<code>:<var>host</var></code>]</dt>

WARNING: Line is 110 characters long (recommended limit is 79)
#821 FILE: ovn-isb.xml:449:
              type='{"type": "string", "enum": ["set", ["VOID", "BACKOFF", "CONNECTING", "ACTIVE", "IDLE"]]}'>

WARNING: Line is 94 characters long (recommended limit is 79)
#1167 FILE: utilities/ovn-isbctl.8.xml:4:
    <p>ovn-isbctl -- Open Virtual Network interconnection southbound db management utility</p>

WARNING: Line is 94 characters long (recommended limit is 79)
#1170 FILE: utilities/ovn-isbctl.8.xml:7:
    <p><code>ovn-isbctl</code> [<var>options</var>] <var>command</var> [<var>arg</var>...]</p>

WARNING: Line is 90 characters long (recommended limit is 79)
#1173 FILE: utilities/ovn-isbctl.8.xml:10:
    <p>This utility can be used to manage the OVN interconnection southbound database.</p>

WARNING: Line is 81 characters long (recommended limit is 79)
#1193 FILE: utilities/ovn-isbctl.8.xml:30:
    <p>These commands query and modify the contents of <code>ovsdb</code> tables.

WARNING: Line is 90 characters long (recommended limit is 79)
#1195 FILE: utilities/ovn-isbctl.8.xml:32:
    as such they operate at a lower level than other <code>ovn-isbctl</code> commands.</p>

WARNING: Line is 82 characters long (recommended limit is 79)
#1197 FILE: utilities/ovn-isbctl.8.xml:34:
    <p>Each of these commands has a <var>table</var> parameter to identify a table

WARNING: Line is 87 characters long (recommended limit is 79)
#1221 FILE: utilities/ovn-isbctl.8.xml:58:
    <xi:include href="lib/db-ctl-base.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 114 characters long (recommended limit is 79)
#1235 FILE: utilities/ovn-isbctl.8.xml:72:
      <dt>[<code>--inactivity-probe=</code><var>msecs</var>] <code>set-connection</code> <var>target</var>...</dt>

WARNING: Line is 80 characters long (recommended limit is 79)
#1238 FILE: utilities/ovn-isbctl.8.xml:75:
        <code>--inactivity-probe=</code><var>msecs</var> to override the default

WARNING: Line is 83 characters long (recommended limit is 79)
#1239 FILE: utilities/ovn-isbctl.8.xml:76:
        idle connection inactivity probe time.  Use 0 to disable inactivity probes.

WARNING: Line is 83 characters long (recommended limit is 79)
#1270 FILE: utilities/ovn-isbctl.8.xml:107:
      Otherwise, the default is <code>unix:@RUNDIR@/ovnisb_db.sock</code>, but this

WARNING: Line is 80 characters long (recommended limit is 79)
#1282 FILE: utilities/ovn-isbctl.8.xml:119:
      <code>--no-leader-only</code>, <code>ovn-isbctl</code> will use any server

WARNING: Line is 80 characters long (recommended limit is 79)
#1292 FILE: utilities/ovn-isbctl.8.xml:129:
    <xi:include href="lib/vlog.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 81 characters long (recommended limit is 79)
#1297 FILE: utilities/ovn-isbctl.8.xml:134:
    <xi:include href="lib/table.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 89 characters long (recommended limit is 79)
#1305 FILE: utilities/ovn-isbctl.8.xml:142:
    <xi:include href="lib/ssl-bootstrap.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 82 characters long (recommended limit is 79)
#1309 FILE: utilities/ovn-isbctl.8.xml:146:
    <xi:include href="lib/common.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line lacks whitespace around operator
#1619 FILE: utilities/ovn-isbctl.c:302:
  get-connection             print the connections\n\

WARNING: Line lacks whitespace around operator
#1620 FILE: utilities/ovn-isbctl.c:303:
  del-connection             delete the connections\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1621 FILE: utilities/ovn-isbctl.c:304:
  [--inactivity-probe=MSECS]\n\

WARNING: Line lacks whitespace around operator
#1622 FILE: utilities/ovn-isbctl.c:305:
  set-connection TARGET...   set the list of connections to TARGET...\n\

WARNING: Line lacks whitespace around operator
#1625 FILE: utilities/ovn-isbctl.c:308:
  get-ssl                     print the SSL configuration\n\

WARNING: Line lacks whitespace around operator
#1626 FILE: utilities/ovn-isbctl.c:309:
  del-ssl                     delete the SSL configuration\n\

WARNING: Line lacks whitespace around operator
#1627 FILE: utilities/ovn-isbctl.c:310:
  set-ssl PRIV-KEY CERT CA-CERT [SSL-PROTOS [SSL-CIPHERS]] \

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1634 FILE: utilities/ovn-isbctl.c:317:
  --db=DATABASE               connect to DATABASE\n\

WARNING: Line lacks whitespace around operator
#1636 FILE: utilities/ovn-isbctl.c:319:
  --no-leader-only            accept any cluster member, not just the leader\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1637 FILE: utilities/ovn-isbctl.c:320:
  -t, --timeout=SECS          wait at most SECS seconds\n\

WARNING: Line lacks whitespace around operator
#1638 FILE: utilities/ovn-isbctl.c:321:
  --dry-run                   do not commit changes to database\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#1645 FILE: utilities/ovn-isbctl.c:328:
  --no-syslog             equivalent to --verbose=isbctl:syslog:warn\n");

WARNING: Comment with 'xxx' marker
#2143 FILE: utilities/ovn-isbctl.c:826:
        /* XXX add verification that table is empty */

Lines checked: 2338, Warnings: 53, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list