[ovs-dev] [PATCH ovn v2 04/13] ovn-ic: Interconnection controller with AZ registeration.

0-day Robot robot at bytheb.org
Wed Oct 30 22:05:30 UTC 2019


Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#125 FILE: ic/ovn-ic.8.xml:54:
    <xi:include href="lib/daemon.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line is 80 characters long (recommended limit is 79)
#128 FILE: ic/ovn-ic.8.xml:57:
    <xi:include href="lib/vlog.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#266 FILE: ic/ovn-ic.c:78:
  --ovnnb-db=DATABASE       connect to ovn-nb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#268 FILE: ic/ovn-ic.c:80:
  --ovnsb-db=DATABASE       connect to ovn-sb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#270 FILE: ic/ovn-ic.c:82:
  --unixctl=SOCKET          override default control socket name\n\

WARNING: Comment with 'xxx' marker
#485 FILE: ic/ovn-ic.c:297:
    /* ovn-nb db. XXX: add only needed tables and columns */

WARNING: Comment with 'xxx' marker
#489 FILE: ic/ovn-ic.c:301:
    /* ovn-sb db. XXX: add only needed tables and columns */

WARNING: Line is 111 characters long (recommended limit is 79)
#1084 FILE: tutorial/ovs-sandbox:406:
    PATH=$builddir/controller:$builddir/controller-vtep:$builddir/northd:$builddir/ic:$builddir/utilities:$PATH

Lines checked: 1124, Warnings: 13, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot


More information about the dev mailing list