[ovs-dev] [PATCH ovn v2 11/13] ovn-ctl: Refactor to reduce redundant code.

0-day Robot robot at bytheb.org
Wed Oct 30 22:13:36 UTC 2019

Bleep bloop.  Greetings Han Zhou, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.

WARNING: Line is 83 characters long (recommended limit is 79)
#58 FILE: utilities/ovn-ctl:72:
        echo "$sync_from_proto:$sync_from_addr:$sync_from_port" > $active_conf_file

WARNING: Line is 104 characters long (recommended limit is 79)
#65 FILE: utilities/ovn-ctl:76:
        ovn-appctl -t $OVN_RUNDIR/$ctl_file ovsdb-server/set-active-ovsdb-server `cat $active_conf_file`

WARNING: Line is 84 characters long (recommended limit is 79)
#66 FILE: utilities/ovn-ctl:77:
        ovn-appctl -t $OVN_RUNDIR/$ctl_file ovsdb-server/connect-active-ovsdb-server

Lines checked: 115, Warnings: 3, Errors: 0

Please check this out.  If you feel there has been an error, please email aconole at redhat.com

0-day Robot

More information about the dev mailing list