[ovs-dev] [PATCH v4 1/2] netdev-dpdk: add dpdk support to the if-notifier API

Eelco Chaudron echaudro at redhat.com
Thu Oct 31 14:26:32 UTC 2019


On 31 Oct 2019, at 15:21, Ilya Maximets wrote:

> On 31.10.2019 13:12, Eelco Chaudron wrote:
>> This patch adds support for DPDK to notify link layer changes trough
>> the if_notifier_xxx() APIs.
>>
>> Signed-off-by: Eelco Chaudron <echaudro at redhat.com>
>> ---
>>   lib/automake.mk        |    4 ++
>>   lib/if-notifier-dpdk.c |   82 
>> ++++++++++++++++++++++++++++++++++++++++++++++++
>>   lib/if-notifier-dpdk.h |   46 +++++++++++++++++++++++++++
>>   lib/if-notifier.c      |   21 +++++++++++-
>>   4 files changed, 149 insertions(+), 4 deletions(-)
>>   create mode 100644 lib/if-notifier-dpdk.c
>>   create mode 100644 lib/if-notifier-dpdk.h
>
>
> Looking at all of this code I think that it might be too heavy
> for just a single function to increment single sequence number.
>
> Another approach:
> Maybe we could just call rtnetlink_report_link() as a workaround.
> netdev-dpdk is Linux dependent right now anyway.
> What do you think?

That would work, but it’s not really thread safe, as its will be 
called from the eal interrupt thread

//Eelco



More information about the dev mailing list