[ovs-dev] [PATCH dpdk-latest v2] dpdk: Migrate to the new pdump API.
david.marchand at redhat.com
Thu Oct 31 15:35:15 UTC 2019
On Thu, Oct 31, 2019 at 2:15 PM Ilya Maximets <i.maximets at ovn.org> wrote:
> DPDK commit 660098d61f57 ("pdump: use generic multi-process channel")
> switched pdump to use generic DPDK IPC instead of sockets.
> Old API was deprecated and removed. Updating OVS code accordingly.
> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
> Version 2:
> * Removed unneeded deinitialization on error.
> * Docs updated.
> Documentation/topics/dpdk/pdump.rst | 9 ++-------
> lib/dpdk.c | 11 +----------
> 2 files changed, 3 insertions(+), 17 deletions(-)
> diff --git a/Documentation/topics/dpdk/pdump.rst b/Documentation/topics/dpdk/pdump.rst
> index 7bd1d3e9f..26acff45e 100644
> --- a/Documentation/topics/dpdk/pdump.rst
> +++ b/Documentation/topics/dpdk/pdump.rst
> @@ -41,8 +41,7 @@ To use pdump, simply launch OVS as usual, then navigate to the ``app/pdump``
> directory in DPDK, ``make`` the application and run like so::
> $ sudo ./build/app/dpdk-pdump -- \
> - --pdump port=0,queue=0,rx-dev=/tmp/pkts.pcap \
> - --server-socket-path=/usr/local/var/run/openvswitch
> + --pdump port=0,queue=0,rx-dev=/tmp/pkts.pcap
You still need to instruct the secondary process where to find the
dpdk configuration and mp_socket.
In my test, ovs running as openvswitch user, I had to:
# sudo -u openvswitch XDG_RUNTIME_DIR=/var/run/openvswitch
./dpdk/v18.11.2/app/dpdk-pdump -- --pdump
EAL: Detected 28 lcore(s)
EAL: Detected 1 NUMA nodes
EAL: Multi-process socket
EAL: Probing VFIO support...
EAL: VFIO support initialized
dpdk won't look at XDG_RUNTIME_DIR when running as uid 0, which I find
a bit odd and something to change.
I did not find another way to set the runtime directory.
Cc: Anatoly (off this week).
More information about the dev