[ovs-dev] [PATCH] Avoid indeterminate statistics in offload implementations.
blp at ovn.org
Thu Oct 31 17:07:53 UTC 2019
On Wed, Oct 30, 2019 at 08:40:22PM +0100, Ilya Maximets wrote:
> On 25.10.2019 20:46, Ben Pfaff wrote:
> > A lot of the offload implementations didn't bother to initialize the
> > statistics they were supposed to return. I don't know whether any of
> > the callers actually use them, but it looked wrong.
> > Found by inspection.
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> > ---
> > lib/netdev-dummy.c | 10 ++++++++--
> > lib/netdev-offload-dpdk.c | 10 ++++++++--
> > lib/netdev-offload-tc.c | 5 ++++-
> > 3 files changed, 20 insertions(+), 5 deletions(-)
> This looks correct.
> 'dummy' and 'dpdk' implementations doesn't support stats at all, so
> these should be cleared. 'tc' needs some more work to return stats
> on flow replacing, but this should be a separate change.
> Acked-by: Ilya Maximets <i.maximets at ovn.org>
Thanks, applied to master and branch-2.12.
More information about the dev