[ovs-dev] [PATCH v3 ovn] ovn-nb/sbctl.c: Use env variables for passing options.

Numan Siddique numans at ovn.org
Thu Oct 31 18:15:07 UTC 2019


On Sat, Oct 26, 2019 at 2:02 AM Ben Pfaff <blp at ovn.org> wrote:
>
> On Fri, Oct 25, 2019 at 01:10:57PM -0700, amginwal at gmail.com wrote:
> > From: Aliasgar Ginwala <aginwala at ebay.com>
> >
> > Add new env variables OVN_NBCTL_OPTIONS and OVN_SBCTL_OPTIONS for
> > ovn-nbctl and ovn-sbctl respectively where user can set
> > supported ovn-nb/sbctl options using environment variable.
> > e.g. OVN_SBCTL_OPTIONS="--db=unix:sb1.ovsdb --no-leader-only"
> >
> > Signed-off-by: Aliasgar Ginwala <aginwala at ebay.com>
>
> I didn't test this.
>
> Acked-by: Ben Pfaff <blp at ovn.org>

Hi Aliasgar,

Compilation was failing with the below errors
****

utilities/ovn-sbctl.8:286: warning: macro `User' not defined
utilities/ovn-sbctl.8:287: warning: macro `variable.' not defined
utilities/ovn-sbctl.8:288: warning: macro `export' not defined
(possibly missing space after `ex')
utilities/ovn-sbctl.8:289: warning: macro `However' not defined
utilities/ovn-sbctl.8:290: warning: macro `options' not defined
utilities/ovn-sbctl.8:291: warning: macro `e.g.:' not defined

****

I applied this patch to master with the below changes to fix the
compilation errors.

Thanks
Numan


********************
diff --git a/utilities/ovn-sbctl.8.in b/utilities/ovn-sbctl.8.in
index b3c21d625..644f94432 100644
--- a/utilities/ovn-sbctl.8.in
+++ b/utilities/ovn-sbctl.8.in
@@ -94,12 +94,12 @@ would normally happen only if the database cannot
be contacted, or if
 the system is overloaded.)
 .
 .IP "\fBOVN_SBCTL_OPTIONS\fR"
-.User can set one or more options using \fBOVN_SBCTL_OPTIONS\fR environment
-.variable. Under the Bourne shell this might be done like this:
-.export \fBOVN_SBCTL_OPTIONS\fR"="--db=unix:sb1.ovsdb --no-leader-only".
-.However user can still over-ride environment options by passing different
-.options in cli. When the environment variable is no longer needed, unset it,
-.e.g.: unset \fBOVN_SBCTL_OPTIONS\fR"
+User can set one or more options using \fBOVN_SBCTL_OPTIONS\fR environment
+variable. Under the Bourne shell this might be done like this:
+export \fBOVN_SBCTL_OPTIONS\fR"="--db=unix:sb1.ovsdb --no-leader-only".
+However user can still over-ride environment options by passing different
+options in cli. When the environment variable is no longer needed, unset it,
+e.g.: unset \fBOVN_SBCTL_OPTIONS\fR"
 .
 .so lib/vlog.man
 .so lib/common.man
**********
> _______________________________________________
> dev mailing list
> dev at openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev


More information about the dev mailing list