[ovs-dev] [PATCH] ip_gre: Removed unused ipgre netdev ops

Gregory Rose gvrose8192 at gmail.com
Thu Oct 31 21:03:54 UTC 2019


Please hold off on this - there's more code to excise.  I'll send along a V2

Thanks,

- Greg

On 10/31/2019 1:30 PM, Greg Rose wrote:
> When cleaning up unused ipgre code the ipgre_netdev_ops structure
> was missed. Get rid of it now.
>
> Fixes: d5822f428814 ("gre: Remove dead ipgre code")
> Signed-off-by: Greg Rose <gvrose8192 at gmail.com>
> ---
>   datapath/linux/compat/ip_gre.c | 16 ----------------
>   1 file changed, 16 deletions(-)
>
> diff --git a/datapath/linux/compat/ip_gre.c b/datapath/linux/compat/ip_gre.c
> index 2852dad..3b7e607 100644
> --- a/datapath/linux/compat/ip_gre.c
> +++ b/datapath/linux/compat/ip_gre.c
> @@ -1024,22 +1024,6 @@ free_skb:
>   	return NETDEV_TX_OK;
>   }
>   
> -static const struct net_device_ops ipgre_netdev_ops = {
> -	.ndo_init		= ipgre_tunnel_init,
> -	.ndo_uninit		= rpl_ip_tunnel_uninit,
> -	.ndo_start_xmit		= ipgre_xmit,
> -#ifdef	HAVE_RHEL7_MAX_MTU
> -	.ndo_size		= sizeof(struct net_device_ops),
> -	.extended.ndo_change_mtu = ip_tunnel_change_mtu,
> -#else
> -	.ndo_change_mtu		= ip_tunnel_change_mtu,
> -#endif
> -	.ndo_get_stats64	= ip_tunnel_get_stats64,
> -#ifdef HAVE_GET_LINK_NET
> -	.ndo_get_iflink		= ip_tunnel_get_iflink,
> -#endif
> -};
> -
>   static const struct net_device_ops gre_tap_netdev_ops = {
>   	.ndo_init		= gre_tap_init,
>   	.ndo_uninit		= rpl_ip_tunnel_uninit,



More information about the dev mailing list