[ovs-dev] [PATCH ovn 1/2] Add ovn-appctl utility
0-day Robot
robot at bytheb.org
Mon Sep 2 17:59:48 UTC 2019
Bleep bloop. Greetings Numan Siddique, I am a robot and I have tried out your patch.
Thanks for your contribution.
I encountered some error that I wasn't expecting. See the details below.
checkpatch:
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#555 FILE: utilities/ovn-appctl.c:90:
-t, --target=TARGET pidfile or socket to contact\n\
WARNING: Line lacks whitespace around operator
#557 FILE: utilities/ovn-appctl.c:92:
list-commands List commands supported by the target\n\
WARNING: Line lacks whitespace around operator
#559 FILE: utilities/ovn-appctl.c:94:
vlog/list List current logging levels\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#560 FILE: utilities/ovn-appctl.c:95:
vlog/list-pattern List logging patterns for each destination.\n\
WARNING: Line lacks whitespace around operator
#561 FILE: utilities/ovn-appctl.c:96:
vlog/set [SPEC]\n\
WARNING: Line lacks whitespace around operator
#566 FILE: utilities/ovn-appctl.c:101:
vlog/reopen Make the program reopen its log file\n\
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#568 FILE: utilities/ovn-appctl.c:103:
--timeout=SECS wait at most SECS seconds for a response\n\
WARNING: Line lacks whitespace around operator
#570 FILE: utilities/ovn-appctl.c:105:
-V, --version Display ovs-appctl version information\n",
WARNING: Line is 113 characters long (recommended limit is 79)
#731 FILE: utilities/ovn-ctl:68:
ovn-appctl -t $OVN_RUNDIR/ovnnb_db.ctl ovsdb-server/set-active-ovsdb-server `cat $ovnnb_active_conf_file`
WARNING: Line is 87 characters long (recommended limit is 79)
#732 FILE: utilities/ovn-ctl:69:
ovn-appctl -t $OVN_RUNDIR/ovnnb_db.ctl ovsdb-server/connect-active-ovsdb-server
WARNING: Line is 113 characters long (recommended limit is 79)
#742 FILE: utilities/ovn-ctl:82:
ovn-appctl -t $OVN_RUNDIR/ovnsb_db.ctl ovsdb-server/set-active-ovsdb-server `cat $ovnsb_active_conf_file`
WARNING: Line is 87 characters long (recommended limit is 79)
#743 FILE: utilities/ovn-ctl:83:
ovn-appctl -t $OVN_RUNDIR/ovnsb_db.ctl ovsdb-server/connect-active-ovsdb-server
WARNING: Line is 86 characters long (recommended limit is 79)
#752 FILE: utilities/ovn-ctl:92:
ovn-appctl -t $OVN_RUNDIR/ovnnb_db.ctl ovsdb-server/disconnect-active-ovsdb-server
WARNING: Line is 86 characters long (recommended limit is 79)
#758 FILE: utilities/ovn-ctl:97:
ovn-appctl -t $OVN_RUNDIR/ovnsb_db.ctl ovsdb-server/disconnect-active-ovsdb-server
WARNING: Line is 98 characters long (recommended limit is 79)
#767 FILE: utilities/ovn-ctl:277:
ovn-appctl -t $OVN_RUNDIR/ovn${1}_db.ctl ovsdb-server/sync-status | awk '{if(NR==1) print $2}'
Lines checked: 773, Warnings: 18, Errors: 0
Please check this out. If you feel there has been an error, please email aconole at redhat.com
Thanks,
0-day Robot
More information about the dev
mailing list