[ovs-dev] [PATCH] ovn: Fix broken dist* targets.

Numan Siddique nusiddiq at redhat.com
Wed Sep 11 11:31:10 UTC 2019


On Tue, Sep 10, 2019 at 1:31 PM Ilya Maximets <i.maximets at samsung.com>
wrote:

> Redundant line continuation was missed while removing OVN
> that broke distdir target and subsequently all the dependent
> targets, e.g. distcheck:
>
>   make[1]:
>   *** No rule to make target 'nodist_ovn_lib_libovn_la_SOURCES',
>       needed by 'distdir'.  Stop.
>
> CC: Mark Michelson <mmichels at redhat.com>
> Fixes: f3e24610ea18 ("Remove OVN.")
> Signed-off-by: Ilya Maximets <i.maximets at samsung.com>
>

Acked-by: Numan Siddique <nusiddiq at redhat.com>

There's another cleanup patch if you would like to take a look -
https://patchwork.ozlabs.org/patch/1160181/

Thanks
Numan


> ---
>  ovn/lib/automake.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ovn/lib/automake.mk b/ovn/lib/automake.mk
> index c74430005..53a10e211 100644
> --- a/ovn/lib/automake.mk
> +++ b/ovn/lib/automake.mk
> @@ -7,7 +7,7 @@ ovn_lib_libovn_la_SOURCES = \
>         ovn/lib/acl-log.c \
>         ovn/lib/acl-log.h \
>         ovn/lib/ovn-util.c \
> -       ovn/lib/ovn-util.h \
> +       ovn/lib/ovn-util.h
>  nodist_ovn_lib_libovn_la_SOURCES = \
>         ovn/lib/ovn-nb-idl.c \
>         ovn/lib/ovn-nb-idl.h \
> --
> 2.17.1
>
>


More information about the dev mailing list