[ovs-dev] [PATCH v5 5/7] Fix OVN failing tests.

Michal Obrembski michalx.obrembski at intel.com
Wed Sep 11 14:10:03 UTC 2019


An unnecessary offset has been added while introducing dp_packet_may_pull in
netdev-native-tnl.c

Signed-off-by: Michal Obrembski <michalx.obrembski at intel.com>
---
 lib/netdev-native-tnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/netdev-native-tnl.c b/lib/netdev-native-tnl.c
index 145ae46..54ed0e9 100644
--- a/lib/netdev-native-tnl.c
+++ b/lib/netdev-native-tnl.c
@@ -854,7 +854,7 @@ netdev_geneve_pop_header(struct dp_packet *packet)
 
     opts_len = gnh->opt_len * 4;
     hlen = ulen + GENEVE_BASE_HLEN + opts_len;
-    if (!dp_packet_may_pull(packet, packet->l4_ofs, hlen)) {
+    if (!dp_packet_may_pull(packet, packet->l4_ofs, hlen - ulen)) {
         VLOG_WARN_RL(&err_rl, "geneve packet too small: header len=%u packet size=%u\n",
                      hlen, dp_packet_size(packet));
         goto err;
-- 
2.7.4



More information about the dev mailing list