[ovs-dev] [PATCH 2/3] ovs-check-dead-ifs: unshadow pid variable

Aaron Conole aconole at redhat.com
Fri Sep 13 17:29:02 UTC 2019


The pid variable is being shadowed by the list comprehension in the
os.execvp() call.  This can generate flakes / warnings in some environments
so fix it.

Signed-off-by: Aaron Conole <aconole at redhat.com>
---
 utilities/ovs-check-dead-ifs.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utilities/ovs-check-dead-ifs.in b/utilities/ovs-check-dead-ifs.in
index f398a3401..73e4fd9e1 100755
--- a/utilities/ovs-check-dead-ifs.in
+++ b/utilities/ovs-check-dead-ifs.in
@@ -99,4 +99,4 @@ if bad_pids:
 The following processes are listening for packets to arrive on network devices
 that no longer exist. You may want to restart them.""")
     sys.stdout.flush()
-    os.execvp("ps", ["ps"] + ["%s" % pid for pid in bad_pids])
+    os.execvp("ps", ["ps"] + ["%s" % pspid for pspid in bad_pids])
-- 
2.21.0



More information about the dev mailing list