[ovs-dev] [PATCH v5 2/9] ovs-vsctl: Add conntrack zone commands.

Justin Pettit jpettit at ovn.org
Fri Sep 13 17:48:38 UTC 2019


> On Sep 13, 2019, at 10:41 AM, William Tu <u9012063 at gmail.com> wrote:
> 
>> Is there a reason you limited this to 18 arguments and not use INT_MAX?
> 
> I use 18 because at most we have 11 tcp, 3 udp, 2 icmp, total of 16 and plus
> (dp_name, zone_id), so total is 18.
> I think using INT_MAX is fine, because at db schema, the value type is set.

That's a fair argument.  However, I'd suggest that we let ovs-vswitchd do that enforcement.  It's nice to decouple the configuration tool from the binary as much as possible in case people run different versions.

> I will merge your diff and send next version.

Sounds good.  I'm hopeful that we'll be able to get this version merged with minimal changes, though.

Thanks,

--Justin




More information about the dev mailing list