[ovs-dev] [PATCH 09/10] db-ctl-base: Free leaked ovsdb_datum

William Tu u9012063 at gmail.com
Tue Sep 17 17:44:58 UTC 2019


On Wed, Sep 11, 2019 at 02:18:35PM -0700, Yifeng Sun wrote:
> Valgrind reported:
> 
> 2491: database commands -- negative checks
> 
> ==19245== 36 (32 direct, 4 indirect) bytes in 1 blocks are definitely lost in loss record 36 of 53
> ==19245==    at 0x4C2FD5F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==19245==    by 0x431AB4: xrealloc (util.c:149)
> ==19245==    by 0x41656D: ovsdb_datum_reallocate (ovsdb-data.c:1883)
> ==19245==    by 0x41656D: ovsdb_datum_union (ovsdb-data.c:1961)
> ==19245==    by 0x4107B2: cmd_add (db-ctl-base.c:1494)
> ==19245==    by 0x406E2E: do_vsctl (ovs-vsctl.c:2626)
> ==19245==    by 0x406E2E: main (ovs-vsctl.c:183)
> 
> ==19252== 16 bytes in 1 blocks are definitely lost in loss record 9 of 52
> ==19252==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==19252==    by 0x430F74: xmalloc (util.c:138)
> ==19252==    by 0x414D07: clone_atoms (ovsdb-data.c:990)
> ==19252==    by 0x4153F6: ovsdb_datum_clone (ovsdb-data.c:1012)
> ==19252==    by 0x4104D3: cmd_remove (db-ctl-base.c:1564)
> ==19252==    by 0x406E2E: do_vsctl (ovs-vsctl.c:2626)
> ==19252==    by 0x406E2E: main (ovs-vsctl.c:183)
> 
> This patch fixes them.
> 
> Signed-off-by: Yifeng Sun <pkusunyifeng at gmail.com>

LGTM.
Acked-by: William Tu <u9012063 at gmail.com>

<snip>



More information about the dev mailing list