[ovs-dev] [PATCH] dpdk: Remove unneeded log message copy.

Stokes, Ian ian.stokes at intel.com
Wed Sep 25 17:30:21 UTC 2019



On 9/6/2019 3:18 PM, David Marchand wrote:
> On Fri, Sep 6, 2019 at 3:24 PM Ilya Maximets <i.maximets at samsung.com> wrote:
>>
>> On 06.09.2019 14:26, David Marchand wrote:
>>> No need to duplicate and null-terminate the passed buffer.
>>> We can directly give it to the vlog subsystem using a dynamic precision
>>> in the format string.
>>>
>>> Signed-off-by: David Marchand <david.marchand at redhat.com>
>>> ---
>>
>> Thanks for a patch. Looks good at a first glance.
>>
>> One small nit is that you need a space between "(int)" and "size", but
>> this could be, probably, fixed while applying.
> 
> Tell me, I don't mind sending a v2.
> Thanks!
> 

No need for the v2, can apply on commit.

Thanks
Ian


More information about the dev mailing list