[ovs-dev] [PATCH ovn 1/4] configure: Improve checks for OVS source and build directories.

Ben Pfaff blp at ovn.org
Thu Sep 26 15:50:01 UTC 2019


On Thu, Sep 26, 2019 at 12:07:52PM +0530, Numan Siddique wrote:
> On Thu, Sep 26, 2019 at 12:04 AM Ben Pfaff <blp at ovn.org> wrote:
> 
> > Until now, "configure" was willing to accept anything as the OVS source
> > and build directory, but obviously only an actual OVS source or build
> > directory will actually work.  This commit adds some basic checking.
> >
> > In addition, this changes relative paths so that they are relative to
> > the current working directory when "configure" is invoked, instead of
> > relative to the location of the "configure" script.  This is less
> > surprising.
> >
> > Finally, this moves the `eval echo "$dir"` lines up higher so that they
> > do their intended job of expanding ~ in the right place.  That has to
> > happen early, otherwise, ~/foo will effectively end up as $PWD/\~/foo.
> >
> > Signed-off-by: Ben Pfaff <blp at ovn.org>
> >
> 
> Please consider this Ack for the whole series.
> 
> Acked-by: Numan Siddique <nusiddiq at redhat.com>

Thanks!  I applied this to master.


More information about the dev mailing list