[ovs-dev] [PATCH branch-2.10] dpdk: Use DPDK 17.11.6 release.

Stokes, Ian ian.stokes at intel.com
Mon Sep 30 12:39:57 UTC 2019



On 9/26/2019 11:00 AM, Stokes, Ian wrote:
> 
> 
> On 9/26/2019 10:55 AM, Ilya Maximets wrote:
>> On 26.09.2019 12:46, Kevin Traynor wrote:
>>> On 26/09/2019 09:44, Stokes, Ian wrote:
>>>>
>>>>
>>>> On 9/25/2019 10:50 PM, Ben Pfaff wrote:
>>>>> It looks like these DPDK version update patches have been overlooked.
>>>>> Ilya, Ian, do you want to look at them?
>>>>
>>>> Hi Ben,
>>>>
>>>> sure I can look at them,
>>>>
>>>> I had worked with Lukasz to validate this so was waiting for an ACK 
>>>> from
>>>> someone outside Intel.
>>>>
>>>> Below looks ok to me.
>>>>
>>>> @Kevin/Ilya, any objections to me applying these to branch 2.10 and 
>>>> 2.9?
>>>>
>>>
>>> No objection. 17.11.7 is about to be released, so if for some reason you
>>> were going to do any sort of re-validation etc, it would be better to
>>> wait a few days and pick up 17.11.7, but if it's just pushing then it
>>> seems fine to do. One comment below.
>>
>> Hi Ian and Kevin,
>> I didn't test this, but it seems OK in general for me as far as
>> you've tested it.
>> However, I tend to agree that if we could wait a bit and validate
>> with 17.11.7 this might be better. If we're not going to test with
>> 17.11.7 in a near future, than we could apply this now.
>>
> 
> Yes, we're planning to validate 17.11.7 in the near future anyhow but 
> had completed validation on this so though it would be worth flagging it 
> can be used until we get around to 17.11.7.
> 
>>>
>>>> Regards
>>>> Ian
>>>>
>>>>>
>>>>> On Mon, Sep 02, 2019 at 09:34:53AM +0200, Lukasz Pawlik wrote:
>>>>>> Modify travis linux build script to use the latest DPDK stable 
>>>>>> release
>>>>>> 17.11.6. Update docs for latest DPDK stable releases.
>>>>>>
>>>>>> Signed-off-by: Lukasz Pawlik <lukaszx.pawlik at intel.com>
>>>>>> ---
>>>>>>    .travis/linux-build.sh                   | 2 +-
>>>>>>    Documentation/faq/releases.rst           | 4 ++--
>>>>>>    Documentation/intro/install/dpdk.rst     | 8 ++++----
>>>>>>    Documentation/topics/dpdk/vhost-user.rst | 6 +++---
>>>>>>    NEWS                                     | 2 ++
>>>>>>    5 files changed, 12 insertions(+), 10 deletions(-)
>>>>>>
>>>>>> diff --git a/.travis/linux-build.sh b/.travis/linux-build.sh
>>>>>> index 1fe5bbf..ede62a5 100755
>>>>>> --- a/.travis/linux-build.sh
>>>>>> +++ b/.travis/linux-build.sh
>>>>>> @@ -83,7 +83,7 @@ fi
>>>>>>    if [ "$DPDK" ]; then
>>>>>>        if [ -z "$DPDK_VER" ]; then
>>>>>> -        DPDK_VER="17.11.4"
>>>>>> +        DPDK_VER="17.11.6"
>>>>>>        fi
>>>>>>        install_dpdk $DPDK_VER
>>>>>>        if [ "$CC" = "clang" ]; then
>>>>>> diff --git a/Documentation/faq/releases.rst 
>>>>>> b/Documentation/faq/releases.rst
>>>>>> index 216eb30..8fe16d9 100644
>>>>>> --- a/Documentation/faq/releases.rst
>>>>>> +++ b/Documentation/faq/releases.rst
>>>>>> @@ -167,8 +167,8 @@ Q: What DPDK version does each Open vSwitch 
>>>>>> release work with?
>>>>>>        2.6.x        16.07.2
>>>>>>        2.7.x        16.11.8
>>>>>>        2.8.x        17.05.2
>>>>>> -    2.9.x        17.11.4
>>>>>> -    2.10.x       17.11.4
>>>>>> +    2.9.x        17.11.6
>>>>>> +    2.10.x       17.11.6
>>>>>>        ============ =======
>>>>>>    Q: Are all the DPDK releases that OVS versions work with 
>>>>>> maintained?
>>>>>> diff --git a/Documentation/intro/install/dpdk.rst 
>>>>>> b/Documentation/intro/install/dpdk.rst
>>>>>> index 13546bb..5f39263 100644
>>>>>> --- a/Documentation/intro/install/dpdk.rst
>>>>>> +++ b/Documentation/intro/install/dpdk.rst
>>>>>> @@ -42,7 +42,7 @@ Build requirements
>>>>>>    In addition to the requirements described in :doc:`general`, 
>>>>>> building Open
>>>>>>    vSwitch with DPDK will require the following:
>>>>>> -- DPDK 17.11.4
>>>>>> +- DPDK 17.11.6
>>>>>>    - A `DPDK supported NIC`_
>>>>>> @@ -71,9 +71,9 @@ Install DPDK
>>>>>>    #. Download the `DPDK sources`_, extract the file and set 
>>>>>> ``DPDK_DIR``::
>>>>>>           $ cd /usr/src/
>>>>>> -       $ wget http://fast.dpdk.org/rel/dpdk-17.11.4.tar.xz
>>>>>> -       $ tar xf dpdk-17.11.4.tar.xz
>>>>>> -       $ export DPDK_DIR=/usr/src/dpdk-stable-17.11.4
>>>>>> +       $ wget http://fast.dpdk.org/rel/dpdk-17.11.6.tar.xz
>>>>>> +       $ tar xf dpdk-17.11.6.tar.xz
>>>>>> +       $ export DPDK_DIR=/usr/src/dpdk-stable-17.11.6
>>>>>>           $ cd $DPDK_DIR
>>>>>>    #. (Optional) Configure DPDK as a shared library
>>>>>> diff --git a/Documentation/topics/dpdk/vhost-user.rst 
>>>>>> b/Documentation/topics/dpdk/vhost-user.rst
>>>>>> index 6334590..c5fe9ee 100644
>>>>>> --- a/Documentation/topics/dpdk/vhost-user.rst
>>>>>> +++ b/Documentation/topics/dpdk/vhost-user.rst
>>>>>> @@ -320,9 +320,9 @@ To begin, instantiate a guest as described in 
>>>>>> :ref:`dpdk-vhost-user` or
>>>>>>    DPDK sources to VM and build DPDK::
>>>>>>        $ cd /root/dpdk/
>>>>>> -    $ wget http://fast.dpdk.org/rel/dpdk-17.11.4.tar.xz
>>>>>> -    $ tar xf dpdk-17.11.4.tar.xz
>>>>>> -    $ export DPDK_DIR=/root/dpdk/dpdk-stable-17.11.4
>>>>>> +    $ wget http://fast.dpdk.org/rel/dpdk-17.11.6.tar.xz
>>>>>> +    $ tar xf dpdk-17.11.6.tar.xz
>>>>>> +    $ export DPDK_DIR=/root/dpdk/dpdk-stable-17.11.6
>>>>>>        $ export DPDK_TARGET=x86_64-native-linuxapp-gcc
>>>>>>        $ export DPDK_BUILD=$DPDK_DIR/$DPDK_TARGET
>>>>>>        $ cd $DPDK_DIR
>>>>>> diff --git a/NEWS b/NEWS
>>>>>> index 064550b..92c3f81 100644
>>>>>> --- a/NEWS
>>>>>> +++ b/NEWS
>>>>>> @@ -4,6 +4,8 @@ v2.10.3 - xx xxx xxxx
>>>>>>    v2.10.2 - 30 Mar 2019
>>>>>>    --------------------
>>>>>>       - Bug fixes
>>>>>> +   - DPDK
>>>>>> +    * OVS validated with DPDK 17.11.6 which is recommended to be 
>>>>>> used.
>>>
>>> I guess it's still valid to add this to the 2.10.2 NEWS (even though it
>>> has now been released) as testing would have been done in the context of
>>> 2.10.2 at some point. Similar comment for 2.9 branch.
>>
>> I don't think that it's a good practice to overwrite the history.
>> Anyway, branch 2.10 has already 2.10.4 release, so the change should
>> go to unreleased 2.10.5 section.
> 
> I don't feel too strongly about this so I'm happy to put it in the 
> 2.10.5 section.
> 

I've pushed this to 2.10 and 2.9 and modified the NEWS announcement to 
be under the latest release section. Thanks all for input.

Regards
Ian



More information about the dev mailing list