[ovs-dev] [PATCH 2/2] system-traffic: Check frozen state handling with TLV map change

[William Tu]

On Mon, Apr 6, 2020 at 8:29 AM William Tu <u9012063 at gmail.com> wrote:
>
> Hi Yifeng,
>
> Thanks for the patch, I can reproduce the issue using
> $ make check-system-userspace TESTSUITEFLAGS='-k resume'
> ASAN reports
> ==127707==ERROR: AddressSanitizer: heap-use-after-free on address
> 0x61f000020690 at pc 0x00000089cecf bp 0x7fff38f95690 sp
> 0x7fff38f95688
> READ of size 4 at 0x61f000020690 thread T0
>     #0 0x89cece in tun_metadata_get_fmd /root/ovs/lib/tun-metadata.c:394:52
>     #1 0x66a3f9 in flow_get_metadata /root/ovs/lib/flow.c:1236:5
>     #2 0x58a9ca in process_upcall
> /root/ovs/ofproto/ofproto-dpif-upcall.c:1538:13
>     #3 0x57a723 in upcall_cb /root/ovs/ofproto/ofproto-dpif-upcall.c:1311:13
>
> However, applying your fix (patch 1/2) and run
> $  make check-system-userspace TESTSUITEFLAGS='-k resume'
> fix the crash but trigger other fail.
>
FYI, with your patch, the failed log shows:
+2020-04-06T15:43:08.716Z|00001|dpif(revalidator7)|WARN|netdev at ovs-netdev:
failed to put[modify] (No such file or directory)
ufid:4c0cc511-5dfd-4afe-a43b-86889dcd3600
skb_priority(0/0),tunnel(tun_id=0x0,src=172.31.1.1,dst=172.31.1.100,ttl=64/0,tp_src=62880/0,tp_dst=6081/0,flags(-df-csum+key)),skb_mark(0/0),ct_state(0/0),ct_zone(0/0),ct_mark(0/0),ct_label(0/0),recirc_id(0),dp_hash(0/0),in_port(4),packet_type(ns=0,id=0),eth(src=ee:b9:ef:c8:ab:57/00:00:00:00:00:00,dst=33:33:00:00:00:16/00:00:00:00:00:00),eth_type(0x86dd),ipv6(src=::/::,dst=ff02::16/::,label=0/0,proto=58/0,tclass=0/0,hlimit=1/0,frag=no),icmpv6(type=143/0,code=0/0),
actions:userspace(pid=0,controller(reason=7,dont_send=0,continuation=0,recirc_id=7,rule_cookie=0,controller_id=0,max_len=65535))
+2020-04-06T15:43:08.716Z|00002|dpif(revalidator7)|WARN|netdev at ovs-netdev:
failed to put[modify] (No such file or directory)
ufid:e7d78a37-7dd8-4641-a71d-1c57e4b47329
skb_priority(0/0),tunnel(tun_id=0x0,src=172.31.1.1,dst=172.31.1.100,ttl=64/0,tp_src=22243/0,tp_dst=6081/0,flags(-df-csum+key)),skb_mark(0/0),ct_state(0/0),ct_zone(0/0),ct_mark(0/0),ct_label(0/0),recirc_id(0),dp_hash(0/0),in_port(4),packet_type(ns=0,id=0),eth(src=ee:b9:ef:c8:ab:57/00:00:00:00:00:00,dst=f2:7d:a0:68:ae:4a/00:00:00:00:00:00),eth_type(0x0800),ipv4(src=10.1.1.1/0.0.0.0,dst=10.1.1.100/0.0.0.0,proto=1,tos=0/0,ttl=64/0,frag=no),icmp(type=8/0,code=0/0),
actions:userspace(pid=0,controller(reason=1,dont_send=0,continuation=1,recirc_id=8,rule_cookie=0,controller_id=0,max_len=65535))