[ovs-dev] [PATCH v4 0/3] Avoid ovsdb-idl IDL inconsistencies.

Dumitru Ceara dceara at redhat.com
Wed Apr 22 18:38:05 UTC 2020


This series contains:
- patch1: update to the monitor_cond_change documentation in ovsdb-server to
  reflect what updates are sent when monitor_cond_since method is used.
- patch2: fix for a bug that could cause client IDLs to end up in inconsistent
  states when using OVSDB_MONITOR_V3.
- patch3: a generic recovery mechanism which triggers an IDL retry with fast
  resync disabled in case the IDL ended up in an inconsistent state.

CC: Han Zhou <hzhou at ovn.org>
CC: Andy Zhou <azhou at ovn.org>
CC: Ilya Maximets <i.maximets at ovn.org>
Fixes: 403a6a0cb003 ("ovsdb-idl: Fast resync from server when connection reset.")
Fixes: db2b5757328c ("lib: add monitor2 support in ovsdb-idl.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>

Dumitru Ceara (3):
      ovsdb-server.7: Mention update3 as replies to monitor_cond_change.
      ovsdb-idl: Avoid inconsistent IDL state with OVSDB_MONITOR_V3.
      ovsdb-idl: Force IDL retry when missing updates encountered.


 Documentation/ref/ovsdb-server.7.rst |    6 ++--
 lib/ovsdb-idl.c                      |   56 ++++++++++++++++++++++++++++++++--
 2 files changed, 55 insertions(+), 7 deletions(-)

---
V4:
- Address Ilya's comments:
  - split in series (doc fix + bug fix + recovery mechanism).
  - use uuid_zero() instead of memset.
  - move clearing of db->last_id to ovsdb_idl_restart_fsm() and update
    condition such that we cover all cases.
V3:
- Change commit title.
- Update commit message.
- Fix monitor_cond_since ovsdb-idl implementation.
V2:
- Address Mark's comments:
  - change the error log message to reflect the action taken.
  - use ovsdb_error() instead of ovsdb_syntax_error().



More information about the dev mailing list