[ovs-dev] [PATCH] ovsdb: Remove duplicated function defintions

William Tu u9012063 at gmail.com
Mon Apr 27 15:42:06 UTC 2020


On Tue, Apr 21, 2020 at 03:09:05PM -0700, Yi-Hung Wei wrote:
> ovsdb_function_from_string() and ovsdb_function_to_string() are defined
> both in ovsdb/condition.c and lib/ovsdb-condidtion.c with the same function
> definition.  Remove the one in ovsdb/condition.c to avoid duplication.
> 
> This also resolves the following bazel building error.
> 
> ./libopenvswitch.lo(ovsdb-condition.pic.o): In function `ovsdb_function_from_string':
> /lib/ovsdb-condition.c:24: multiple definition of `ovsdb_function_from_string'
> ./libovsdb.a(condition.pic.o):/proc/self/cwd/external/openvswitch_repo/ovsdb/condition.c:34: first defined here
> ./libopenvswitch.lo(ovsdb-condition.pic.o): In function `ovsdb_function_from_string':
> ./lib/ovsdb-condition.c:24: multiple definition of `ovsdb_function_to_string'
> ./libovsdb.a(condition.pic.o):/proc/self/cwd/external/openvswitch_repo/ovsdb/condition.c:335
> 
> Reported-by: Harold Lim <haroldl at vmware.com>
> Signed-off-by: Yi-Hung Wei <yihung.wei at gmail.com>
> ---
> Travis-CI: https://travis-ci.org/github/YiHungWei/ovs/builds/677890120
Applied to master, thanks
William



More information about the dev mailing list