[ovs-dev] [PATCH v4 4/5] bpf: Add reference XDP program implementation for netdev-offload-xdp

[Toshiaki Makita]

On 2020/07/31 13:07, 0-day Robot wrote:
> Bleep bloop.  Greetings Toshiaki Makita, I am a robot and I have tried out your patch.
> Thanks for your contribution.
> 
> I encountered some error that I wasn't expecting.  See the details below.
> 
> 
> checkpatch:
> ERROR: Improper whitespace around control block
> #494 FILE: bpf/bpf_netlink.h:57:
> #define BPF_MAP_NL_ATTR_FOR_EACH(OFF, ATTRS, START, END, IDX, MAX_ATTRS, \

Actually I could not fix this.
Adding a whitespace resulted in compile error:

flowtable_afxdp.c:541:5: error: use of undeclared identifier 'OFF'
     BPF_MAP_NL_ATTR_FOR_EACH (offset, attrs, start, end, i, XDP_MAX_ACTIONS,
     ^
./bpf_netlink.h:57:35: note: expanded from macro 'BPF_MAP_NL_ATTR_FOR_EACH'
#define BPF_MAP_NL_ATTR_FOR_EACH (OFF, ATTRS, START, END, IDX, MAX_ATTRS, \
                                   ^

Toshiaki Makita