[ovs-dev] [PATCH v2] connmgr: support changing openflow versions without restarting

Ilya Maximets i.maximets at ovn.org
Mon Aug 17 21:41:34 UTC 2020


On 8/12/20 10:07 PM, Aaron Conole wrote:
> When commit a0baa7dfa4fe ("connmgr: Make treatment of active and passive
> connections more uniform") was applied, it did not take into account
> that a reconfiguration of the allowed_versions setting would require a
> reload of the ofservice object (only accomplished via a restart of OvS).
> 
> For now, during the reconfigure cycle, we delete the ofservice object and
> then recreate it immediately.  A new test is added to ensure we do not
> break this behavior again.
> 
> Fixes: a0baa7dfa4fe ("connmgr: Make treatment of active and passive connections more uniform")
> Cc: Numan Siddique <numans at ovn.org>
> Cc: Flavio Leitner <fbl at sysclose.org>
> Suggested-by: Ben Pfaff <blp at ovn.org>
> Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1782834
> Signed-off-by: Aaron Conole <aconole at redhat.com>
> ---
> v2: Keep most of the original API.
> 
> NOTE: The log on line 607 will flag the 0-day robot, but I thought
>       for string searching purposes it's better to keep it all one
>       line.

Thanks, Aaron, Flavio and Numan!

This is actually easy to split the long line near the '%s' without
loosing any grep-ability.  So, I did that and applied to master.
backported down to 2.12.

Best regards, Ilya Maximets.


More information about the dev mailing list