[ovs-dev] [PATCH net-next v1 2/3] net: openvswitch: refactor flow free function

Tonghao Zhang xiangxia.m.yue at gmail.com
Wed Aug 19 23:21:33 UTC 2020


On Thu, Aug 20, 2020 at 6:52 AM David Miller <davem at davemloft.net> wrote:

> From: xiangxia.m.yue at gmail.com
>
> Date: Tue, 18 Aug 2020 18:09:22 +0800
>
>
>
> > Decrease table->count and ufid_count unconditionally,
>
>
>
> You don't explain why this is a valid transformation.
>
>
>
> Is it a bug fix?

No

>
>
>
> Can it never happen?
>
>
>
> What are the details and how did you determine this?

I want to simplify the codes, when flushing the flow, previous codes don't
count the flow, because we have set them(flow counter/ufid counter)to 0.
Now don't set counter and count flow and ufid flow when deleting them, and
I add BUG_ON to make sure other patch no bug when flushing flow.

>
> --
Best regards, Tonghao


More information about the dev mailing list