[ovs-dev] [PATCH ovn 2/2] ovn-controller: Disable ofctrl probe by default.

[Han Zhou]

On Mon, Aug 24, 2020 at 8:06 PM Tony Liu <tonyliu0592 at hotmail.com> wrote:
>
> Nice fix!
> Where is the PR tracked? I don't see it in GitHub issues.

Hi Tony,

Following the same practice of the OVS community, we don't use github for
code reviews or bug tracking, at least not yet for now.

> Where should I report issues?

You can report issues in the ovs-discuss ML.

> How can I check which release it's going to be included?

Usually only critical bug fixes are backported to released branches,
otherwise will be released in the next release cycle. See:

https://github.com/ovn-org/ovn/blob/master/Documentation/internals/release-process.rst#release-scheduling

> Do I have to check the commit history in GitHub?
>

Yes, this is the reliable way to confirm which release has which individual
patch.

Thanks,
Han


>
> Thanks!
> Tony
> > -----Original Message-----
> > From: dev <ovs-dev-bounces at openvswitch.org> On Behalf Of Han Zhou
> > Sent: Monday, August 24, 2020 7:05 PM
> > To: dev at openvswitch.org
> > Cc: Han Zhou <hzhou at ovn.org>
> > Subject: [ovs-dev] [PATCH ovn 2/2] ovn-controller: Disable ofctrl probe
> > by default.
> >
> > The commit c99069c8934c ("ovn-controller: Provide the option to
> > configure inactivity probe interval for OpenFlow conn") supports
> > configuring probe interval for the openflow connection of ofctrl module.
> > However, it changed the default behavior. The default OpenFlow
> > connection probe was defaults to 0 (disabled), because the connection is
> > always unix socket (to local OVS br-int bridge).  After that patch it
> > changed to probe every 5 seconds, which was not the intension.
> >
> > This patch restores the default behavior of disabling the probe by
> > setting default value to 0, while keeping the capability of letting user
> > configure it.
> >
> > Cc: Numan Siddique <nusiddiq at redhat.com>
> > Signed-off-by: Han Zhou <hzhou at ovn.org>
> > ---
> >  controller/ovn-controller.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/controller/ovn-controller.c b/controller/ovn-controller.c
> > index 5ca32ac..c383cf3 100644
> > --- a/controller/ovn-controller.c
> > +++ b/controller/ovn-controller.c
> > @@ -76,7 +76,7 @@ static unixctl_cb_func cluster_state_reset_cmd;
> >
> >  #define DEFAULT_BRIDGE_NAME "br-int"
> >  #define DEFAULT_PROBE_INTERVAL_MSEC 5000 -#define
> > OFCTRL_DEFAULT_PROBE_INTERVAL_SEC 5
> > +#define OFCTRL_DEFAULT_PROBE_INTERVAL_SEC 0
> >
> >  #define CONTROLLER_LOOP_STOPWATCH_NAME "ovn-controller-flow-generation"
> >
> > --
> > 2.1.0
> >
> > _______________________________________________
> > dev mailing list
> > dev at openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev