[ovs-dev] [PATCH] test-conntrack: Fix conntrack benchmark by clearing conntrack metadata.

[Ilya Maximets]

On 8/25/20 5:07 PM, Aaron Conole wrote:
> Ilya Maximets <i.maximets at ovn.org> writes:
> 
>> Packets in the benchmark must be treated as new packets, i.e. they
>> should not have conntrack metadata set.  Current code will set up
>> 'pkt->md.conn' after the first run and all subsequent calls will hit
>> the 'fast' processing that is intended for recirculated packets making
>> a false impression that current conntrack implementation is lightning
>> fast.
> 
> Oh no.
> 
>> Before the change:
>>   $ ./ovstest test-conntrack benchmark 4 33554432 32 1
>>   conntrack:   1059 ms
>>
>> After (correct):
>>   $ ./ovstest test-conntrack benchmark 4 33554432 32 1
>>   conntrack:  92785 ms
> 
> That's horrifying.
> 
>> Fixes: 594570ea1cde ("conntrack: Optimize recirculations.")
>> Signed-off-by: Ilya Maximets <i.maximets at ovn.org>
>> ---
> 
> Sadly:
> 
> Acked-by: Aaron Conole <aconole at redhat.com>
> 

Thanks!
Applied to master and backported down to 2.13.

Best regards, Ilya Maximets.