[ovs-dev] [PATCH v2 2/8] ovsdb-idl: Avoid redundant clearing and parsing of received data.

Ben Pfaff blp at ovn.org
Wed Dec 2 06:23:35 UTC 2020


ovsdb_idl_db_parse_monitor_reply() clears the IDL and parses the
received data.  There's no need to do it again afterward.

Signed-off-by: Ben Pfaff <blp at ovn.org>
Fixes: 1b1d2e6daa56 ("ovsdb: Introduce experimental support for clustered databases.")
---
 lib/ovsdb-idl.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/ovsdb-idl.c b/lib/ovsdb-idl.c
index 6334061b4eb3..a4e04be8f0ed 100644
--- a/lib/ovsdb-idl.c
+++ b/lib/ovsdb-idl.c
@@ -819,9 +819,6 @@ ovsdb_idl_process_response(struct ovsdb_idl *idl, struct jsonrpc_msg *msg)
         ovsdb_idl_db_parse_monitor_reply(&idl->data, msg->result,
                                          OVSDB_IDL_MM_MONITOR);
         idl->data.change_seqno++;
-        ovsdb_idl_clear(idl);
-        ovsdb_idl_db_parse_update(&idl->data, msg->result,
-                                  OVSDB_IDL_MM_MONITOR);
         break;
 
     case IDL_S_MONITORING:
-- 
2.28.0



More information about the dev mailing list