[ovs-dev] [PATCH ovn v9 5/7] tests: Improve debuggability of tests.

[0-day Robot]

Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Line is 82 characters long (recommended limit is 79)
#669 FILE: p-set-addresses:13836:
    check ovs-vsctl -- set Interface $iface options:tx_pcap=${pcap_file}-tx.pcap \

WARNING: Line is 135 characters long (recommended limit is 79)
#680 FILE: p-set-addresses:13843:
check ovn-nbctl acl-add ls1 to-lport 3 '(ip4.src==10.0.0.1 || ip4.src==10.0.0.2) && (ip4.dst == 10.0.0.3 || ip4.dst == 10.0.0.4)' allow

WARNING: Line is 136 characters long (recommended limit is 79)
#681 FILE: p-set-addresses:13844:
check ovn-nbctl acl-add ls1 to-lport 3 '(ip4.src==10.0.0.1 || ip4.src==10.0.0.42) && (ip4.dst == 10.0.0.3 || ip4.dst == 10.0.0.4)' allow

WARNING: Line is 85 characters long (recommended limit is 79)
#698 FILE: p-set-addresses:13877:
check ovn-nbctl acl-add ls1 to-lport 3 'ip4.src==10.0.0.1 || ip4.src==10.0.0.1' allow

WARNING: Line is 170 characters long (recommended limit is 79)
#848 FILE: p-set-addresses:21927:
        grep -c "ct(commit,zone=NXM_NX_REG11\\[[0..15\\]],exec(move:NXM_OF_ETH_SRC\\[[\\]]->NXM_NX_CT_LABEL\\[[32..79\\]],load:0x[[0-9]]->NXM_NX_CT_LABEL\\[[80..95\\]]))"

WARNING: Line is 84 characters long (recommended limit is 79)
#852 FILE: p-set-addresses:21931:
        grep -c "actions=move:NXM_NX_CT_LABEL\\[[32..79\\]]->NXM_OF_ETH_DST\\[[\\]]"

WARNING: Line is 106 characters long (recommended limit is 79)
#905 FILE: p-set-addresses:22106:
check ovn-nbctl acl-add pg0 to-lport 1002 "outport == @pg0 && ip4 && tcp.dst >= 80 && tcp.dst <= 82" allow

WARNING: Line is 84 characters long (recommended limit is 79)
#936 FILE: p-set-addresses:22136:
    echo "checking that there are $count ${match:+$match }flows with conj_id=$id..."

WARNING: Line is 116 characters long (recommended limit is 79)
#966 FILE: p-set-addresses:22153:
check ovn-nbctl --wait=hv acl-add pg0 to-lport 1002 "outport == @pg0 && ip4 && udp.dst >= 80 && udp.dst <= 82" allow

WARNING: Line is 110 characters long (recommended limit is 79)
#974 FILE: p-set-addresses:22157:
check ovn-nbctl --wait=hv acl-del pg0 to-lport 1002 "outport == @pg0 && ip4 && tcp.dst >= 80 && tcp.dst <= 82"

WARNING: Line is 116 characters long (recommended limit is 79)
#981 FILE: p-set-addresses:22161:
check ovn-nbctl --wait=hv acl-add pg0 to-lport 1002 "outport == @pg0 && ip4 && tcp.dst >= 80 && tcp.dst <= 82" allow

WARNING: Line is 134 characters long (recommended limit is 79)
#992 FILE: p-set-addresses:22167:
check ovn-nbctl --wait=hv acl-add pg0 to-lport 1002 "outport == @pg0 && inport == @pg0 && ip4 && tcp.dst >= 84 && tcp.dst <= 86" allow

WARNING: Line is 116 characters long (recommended limit is 79)
#1007 FILE: p-set-addresses:22175:
check ovn-nbctl --wait=hv acl-add pg0 to-lport 1002 "outport == @pg0 && ip4 && tcp.dst >= 80 && tcp.dst <= 82" allow

WARNING: Line is 106 characters long (recommended limit is 79)
#1008 FILE: p-set-addresses:22176:
check ovn-nbctl acl-add pg0 to-lport 1002 "outport == @pg0 && ip4 && udp.dst >= 80 && udp.dst <= 82" allow

Lines checked: 1099, Warnings: 14, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot