[ovs-dev] [PATCH ovn v9 7/7] ovn-northd-ddlog: New implementation of ovn-northd based on ddlog.

[0-day Robot]

Bleep bloop.  Greetings Ben Pfaff, I am a robot and I have tried out your patch.
Thanks for your contribution.

I encountered some error that I wasn't expecting.  See the details below.


checkpatch:
WARNING: Comment with 'xxx' marker
#3534 FILE: northd/ovn-northd-ddlog.c:164:
        .cs = ovsdb_cs_create(database, 1 /* XXX */, &northd_cs_ops, ctx),

WARNING: Comment with 'xxx' marker
#4322 FILE: northd/ovn-northd-ddlog.c:952:
     * XXX If the transaction we're sending to the database fails, then

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#4375 FILE: northd/ovn-northd-ddlog.c:1005:
  --ovnnb-db=DATABASE       connect to ovn-nb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#4377 FILE: northd/ovn-northd-ddlog.c:1007:
  --ovnsb-db=DATABASE       connect to ovn-sb database at DATABASE\n\

WARNING: Line lacks whitespace around operator
WARNING: Line lacks whitespace around operator
#4379 FILE: northd/ovn-northd-ddlog.c:1009:
  --unixctl=SOCKET          override default control socket name\n\

WARNING: Line has trailing whitespace
#6140 FILE: northd/ovn_northd.dl:177:
    var l3dgw_port = peer.and_then(|p| p.router.l3dgw_port),    

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#8808 FILE: northd/ovn_northd.dl:2845:
     

WARNING: Line has non-spaces leading whitespace
WARNING: Line has trailing whitespace
#13416 FILE: northd/ovn_northd.dl:7453:
    

Lines checked: 14016, Warnings: 15, Errors: 0


Please check this out.  If you feel there has been an error, please email aconole at redhat.com

Thanks,
0-day Robot